Commit 24461d97 authored Dec 20, 2019 by Peter Ujfalusi Committed by Vinod Koul Dec 23, 2019

dmaengine: virt-dma: Fix access after free in vchan_complete()



vchan_vdesc_fini() is freeing up 'vd' so the access to vd->tx_result is
via already freed up memory.

Move the vchan_vdesc_fini() after invoking the callback to avoid this.

Fixes: 09d5b702 ("dmaengine: virt-dma: store result on dma descriptor")
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Link: https://lore.kernel.org/r/20191220131100.21804-1-peter.ujfalusi@ti.com


Signed-off-by: Vinod Koul <vkoul@kernel.org>

parent 2f42e05b

drivers/dma/virt-dma.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -104,9 +104,8 @@ static void vchan_complete(unsigned long arg)
		dmaengine_desc_get_callback(&vd->tx, &cb);

		list_del(&vd->node);
		vchan_vdesc_fini(vd);

		dmaengine_desc_callback_invoke(&cb, &vd->tx_result);
		vchan_vdesc_fini(vd);
		}
		}

Admin message