Commit 243abd5b authored Jul 10, 2017 by Naoya Horiguchi Committed by Linus Torvalds Jul 10, 2017

mm: hugetlb: prevent reuse of hwpoisoned free hugepages

Patch series "mm: hwpoison: fixlet for hugetlb migration".

This patchset updates the hwpoison/hugetlb code to address 2 reported
issues.

One is madvise(MADV_HWPOISON) failure reported by Intel's lkp robot (see
http://lkml.kernel.org/r/20170417055948.GM31394@yexl-desktop.) First
half was already fixed in mainline, and another half about hugetlb cases
are solved in this series.

Another issue is "narrow-down error affected region into a single 4kB
page instead of a whole hugetlb page" issue, which was tried by Anshuman
(http://lkml.kernel.org/r/20170420110627.12307-1-khandual@linux.vnet.ibm.com)
and I updated it to apply it more widely.

This patch (of 9):

We no longer use MIGRATE_ISOLATE to prevent reuse of hwpoison hugepages
as we did before.  So current dequeue_huge_page_node() doesn't work as
intended because it still uses is_migrate_isolate_page() for this check.
This patch fixes it with PageHWPoison flag.

Link: http://lkml.kernel.org/r/1496305019-5493-2-git-send-email-n-horiguchi@ah.jp.nec.com


Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 241f01fb

mm/hugetlb.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -22,7 +22,6 @@
		#include <linux/rmap.h>
		#include <linux/swap.h>
		#include <linux/swapops.h>
		#include <linux/page-isolation.h>
		#include <linux/jhash.h>

		#include <asm/page.h>
		@@ -872,7 +871,7 @@ static struct page dequeue_huge_page_node_exact(struct hstate h, int nid)
		struct page *page;

		list_for_each_entry(page, &h->hugepage_freelists[nid], lru)
		if (!is_migrate_isolate_page(page))
		if (!PageHWPoison(page))
		break;
		/*
		* if 'non-isolated free hugepage' not found on the list,

mm/memory-failure.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -49,7 +49,6 @@
		#include <linux/swap.h>
		#include <linux/backing-dev.h>
		#include <linux/migrate.h>
		#include <linux/page-isolation.h>
		#include <linux/suspend.h>
		#include <linux/slab.h>
		#include <linux/swapops.h>

Admin message