pstore/ram: Mark ramoops_pstore_write_buf() as notrace (24203036) · Commits · 戴 / test

write_buf() should be marked as notrace, otherwise it is prone to recursion. Though, yet the issue is never triggered in real life, because we run inside the function tracer, where ftrace does its own recurse protection. But it's still no good, plus soon we might switch to our own tracer ops, and then the issue will be fatal. So, let's fix it. Signed-off-by:

Anton Vorontsov <anton.vorontsov@linaro.org>

fs/pstore/ram.c

+6 −6

Original line number	Diff line number	Diff line
		@@ -32,6 +32,7 @@
		#include <linux/ioport.h>
		#include <linux/platform_device.h>
		#include <linux/slab.h>
		#include <linux/compiler.h>
		#include <linux/pstore_ram.h>

		#define RAMOOPS_KERNMSG_HDR "===="
		@@ -181,8 +182,7 @@ static size_t ramoops_write_kmsg_hdr(struct persistent_ram_zone *prz)
		return len;
		}


		static int ramoops_pstore_write_buf(enum pstore_type_id type,
		static int notrace ramoops_pstore_write_buf(enum pstore_type_id type,
		enum kmsg_dump_reason reason,
		u64 *id, unsigned int part,
		const char *buf, size_t size,

Admin message