Commit 2414e021 authored by Jan Beulich's avatar Jan Beulich Committed by Thomas Gleixner
Browse files

x86: Avoid building unused IRQ entry stubs 



When X86_LOCAL_APIC (i.e. unconditionally on x86-64),
first_system_vector will never end up being higher than
LOCAL_TIMER_VECTOR (0xef), and hence building stubs for vectors
0xef...0xff is pointlessly reducing code density. Deal with this at
build time already.

Taking into consideration that X86_64 implies X86_LOCAL_APIC, also
simplify (and hence make easier to read and more consistent with the
change done here) some #if-s in arch/x86/kernel/irqinit.c.

While we could further improve the packing of the IRQ entry stubs (the
four ones now left in the last set could be fit into the four padding
bytes each of the final four sets have) this doesn't seem to provide
any real benefit: Both irq_entries_start and common_interrupt getting
cache line aligned, eliminating the 30th set would just produce 32
bytes of padding between the 29th and common_interrupt.

[ tglx: Folded lguest fix from Dan Carpenter ]

Signed-off-by: default avatarJan Beulich <jbeulich@suse.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: lguest@lists.ozlabs.org
Cc: Rusty Russell <rusty@rustcorp.com.au>
Link: http://lkml.kernel.org/r/54574D5F0200007800044389@mail.emea.novell.com
Link: http://lkml.kernel.org/r/20141115185718.GB6530@mwanda


Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
parent e1067982

arch/x86/include/asm/hw_irq.h

+2 −1
Original line number Diff line number Diff line
@@ -189,7 +189,8 @@ extern __visible void smp_call_function_single_interrupt(struct pt_regs *); 
extern __visible void smp_invalidate_interrupt(struct pt_regs *);

#endif



extern void (*__initconst interrupt[NR_VECTORS-FIRST_EXTERNAL_VECTOR])(void);

extern void (*__initconst interrupt[FIRST_SYSTEM_VECTOR

				    - FIRST_EXTERNAL_VECTOR])(void);

#ifdef CONFIG_TRACING

#define trace_interrupt interrupt

#endif

arch/x86/include/asm/irq_vectors.h

+6 −0
Original line number Diff line number Diff line
@@ -126,6 +126,12 @@ 


#define NR_VECTORS			 256



#ifdef CONFIG_X86_LOCAL_APIC

#define FIRST_SYSTEM_VECTOR		LOCAL_TIMER_VECTOR

#else

#define FIRST_SYSTEM_VECTOR		NR_VECTORS

#endif



#define FPU_IRQ				  13



#define	FIRST_VM86_IRQ			   3

arch/x86/kernel/apic/apic.c

+12 −10
Original line number Diff line number Diff line
@@ -196,7 +196,7 @@ static int disable_apic_timer __initdata; 
int local_apic_timer_c2_ok;

EXPORT_SYMBOL_GPL(local_apic_timer_c2_ok);



int first_system_vector = 0xfe;

int first_system_vector = FIRST_SYSTEM_VECTOR;



/*

 * Debug level, exported for io_apic.c
@@ -1930,7 +1930,7 @@ int __init APIC_init_uniprocessor(void) 
/*

 * This interrupt should _never_ happen with our APIC/SMP architecture

 */

static inline void __smp_spurious_interrupt(void)

static inline void __smp_spurious_interrupt(u8 vector)

{

	u32 v;
@@ -1939,30 +1939,32 @@ static inline void __smp_spurious_interrupt(void) 
	 * if it is a vectored one.  Just in case...

	 * Spurious interrupts should not be ACKed.

	 */

	v = apic_read(APIC_ISR + ((SPURIOUS_APIC_VECTOR & ~0x1f) >> 1));

	if (v & (1 << (SPURIOUS_APIC_VECTOR & 0x1f)))

	v = apic_read(APIC_ISR + ((vector & ~0x1f) >> 1));

	if (v & (1 << (vector & 0x1f)))

		ack_APIC_irq();



	inc_irq_stat(irq_spurious_count);



	/* see sw-dev-man vol 3, chapter 7.4.13.5 */

	pr_info("spurious APIC interrupt on CPU#%d, "

		"should never happen.\n", smp_processor_id());

	pr_info("spurious APIC interrupt through vector %02x on CPU#%d, "

		"should never happen.\n", vector, smp_processor_id());

}



__visible void smp_spurious_interrupt(struct pt_regs *regs)

{

	entering_irq();

	__smp_spurious_interrupt();

	__smp_spurious_interrupt(~regs->orig_ax);

	exiting_irq();

}



__visible void smp_trace_spurious_interrupt(struct pt_regs *regs)

{

	u8 vector = ~regs->orig_ax;



	entering_irq();

	trace_spurious_apic_entry(SPURIOUS_APIC_VECTOR);

	__smp_spurious_interrupt();

	trace_spurious_apic_exit(SPURIOUS_APIC_VECTOR);

	trace_spurious_apic_entry(vector);

	__smp_spurious_interrupt(vector);

	trace_spurious_apic_exit(vector);

	exiting_irq();

}

arch/x86/kernel/entry_32.S

+2 −2
Original line number Diff line number Diff line
@@ -732,10 +732,10 @@ ENTRY(interrupt) 
ENTRY(irq_entries_start)

	RING0_INT_FRAME

vector=FIRST_EXTERNAL_VECTOR

.rept (NR_VECTORS-FIRST_EXTERNAL_VECTOR+6)/7

.rept (FIRST_SYSTEM_VECTOR-FIRST_EXTERNAL_VECTOR+6)/7

	.balign 32

  .rept	7

    .if vector < NR_VECTORS

    .if vector < FIRST_SYSTEM_VECTOR

      .if vector <> FIRST_EXTERNAL_VECTOR

	CFI_ADJUST_CFA_OFFSET -4

      .endif

arch/x86/kernel/entry_64.S

+2 −2
Original line number Diff line number Diff line
@@ -712,10 +712,10 @@ ENTRY(interrupt) 
ENTRY(irq_entries_start)

	INTR_FRAME

vector=FIRST_EXTERNAL_VECTOR

.rept (NR_VECTORS-FIRST_EXTERNAL_VECTOR+6)/7

.rept (FIRST_SYSTEM_VECTOR-FIRST_EXTERNAL_VECTOR+6)/7

	.balign 32

  .rept	7

    .if vector < NR_VECTORS

    .if vector < FIRST_SYSTEM_VECTOR

      .if vector <> FIRST_EXTERNAL_VECTOR

	CFI_ADJUST_CFA_OFFSET -8

      .endif

CRA Git | Maintained and supported by SUSTech CRA and CCSE