Commit 240c1948 authored Mar 10, 2020 by Julian Wiedmann Committed by David S. Miller Mar 10, 2020

s390/qeth: don't reset default_out_queue

When an OSA device in prio-queue setup is reduced to 1 TX queue due to
HW restrictions, we reset its the default_out_queue to 0.

In the old code this was needed so that qeth_get_priority_queue() gets
the queue selection right. But with proper multiqueue support we already
reduced dev->real_num_tx_queues to 1, and so the stack puts all traffic
on txq 0 without even calling .ndo_select_queue.

Thus we can preserve the user's configuration, and apply it if the OSA
device later re-gains support for multiple TX queues.

Fixes: 73dc2daf ("s390/qeth: add TX multiqueue support for OSA devices")
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent a2d8bf77

drivers/s390/net/qeth_core_main.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -1204,7 +1204,6 @@ static int qeth_osa_set_output_queues(struct qeth_card *card, bool single)
		if (count == 1)
		dev_info(&card->gdev->dev, "Priority Queueing not supported\n");

		card->qdio.default_out_queue = single ? 0 : QETH_DEFAULT_QUEUE;
		card->qdio.no_out_queues = count;
		return 0;
		}

Admin message