fpga manager: xilinx-spi: remove unneeded, mistyped variables (23f872b6) · Commits · 戴 / test

Using variables does not add readability here: parameters passed to udelay*() are obviously in microseconds and their meaning is clear from the context. The type is also wrong, udelay expects an unsigned long. Signed-off-by:

Luca Ceresoli <luca@lucaceresoli.net> Signed-off-by:

Moritz Fischer <mdf@kernel.org>

drivers/fpga/xilinx-spi.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -41,8 +41,6 @@ static int xilinx_spi_write_init(struct fpga_manager *mgr,
		const char *buf, size_t count)
		{
		struct xilinx_spi_conf *conf = mgr->priv;
		const size_t prog_latency_7500us = 7500;
		const size_t prog_pulse_1us = 1;

		if (info->flags & FPGA_MGR_PARTIAL_RECONFIG) {
		dev_err(&mgr->dev, "Partial reconfiguration not supported.\n");
		@@ -51,7 +49,7 @@ static int xilinx_spi_write_init(struct fpga_manager *mgr,

		gpiod_set_value(conf->prog_b, 1);

		udelay(prog_pulse_1us); /* min is 500 ns */
		udelay(1); /* min is 500 ns */

		gpiod_set_value(conf->prog_b, 0);

		@@ -61,7 +59,7 @@ static int xilinx_spi_write_init(struct fpga_manager *mgr,
		}

		/* program latency */
		usleep_range(prog_latency_7500us, prog_latency_7500us + 100);
		usleep_range(7500, 7600);
		return 0;
		}

Admin message