Commit 23ec47a0 authored Nov 11, 2005 by Vladislav Yasevich Committed by David S. Miller Nov 11, 2005

[SCTP]: Fix potential NULL pointer dereference in sctp_v4_get_saddr



It is possible to get to sctp_v4_get_saddr() without a valid
association.  This happens when processing OOTB packets and
the cached route entry is no longer valid.
However, when responding to OOTB packets we already properly
set the source address based on the information in the OOTB
packet.  So, if we we get to sctp_v4_get_saddr() without an
association we can simply return.

Signed-off-by: Vladislav Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: Sridhar Samudrala <sri@us.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 8eb55910

net/sctp/protocol.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -530,6 +530,9 @@ static void sctp_v4_get_saddr(struct sctp_association *asoc,
		{
		struct rtable rt = (struct rtable )dst;

		if (!asoc)
		return;

		if (rt) {
		saddr->v4.sin_family = AF_INET;
		saddr->v4.sin_port = asoc->base.bind_addr.port;

Admin message