IB/core: Fix possible memory leak in cma_resolve_iboe_route() (23d70503) · Commits · 戴 / test

'work' and 'route->path_rec' are malloced in cma_resolve_iboe_route() and should be freed before leaving from the error handling cases, otherwise it will cause memory leak. Fixes: ('IB/core: Validate route when we init ah') Signed-off-by:

Wei Yongjun <weiyj.lk@gmail.com> Reviewed-by:

Haggai Eran <haggaie@mellanox.com> Signed-off-by:

Doug Ledford <dledford@redhat.com>

drivers/infiniband/core/cma.c

+12 −6

Original line number	Diff line number	Diff line
		@@ -2462,18 +2462,24 @@ static int cma_resolve_iboe_route(struct rdma_id_private *id_priv)

		if (addr->dev_addr.bound_dev_if) {
		ndev = dev_get_by_index(&init_net, addr->dev_addr.bound_dev_if);
		if (!ndev)
		return -ENODEV;
		if (!ndev) {
		ret = -ENODEV;
		goto err2;
		}

		if (ndev->flags & IFF_LOOPBACK) {
		dev_put(ndev);
		if (!id_priv->id.device->get_netdev)
		return -EOPNOTSUPP;
		if (!id_priv->id.device->get_netdev) {
		ret = -EOPNOTSUPP;
		goto err2;
		}

		ndev = id_priv->id.device->get_netdev(id_priv->id.device,
		id_priv->id.port_num);
		if (!ndev)
		return -ENODEV;
		if (!ndev) {
		ret = -ENODEV;
		goto err2;
		}
		}

		route->path_rec->net = &init_net;

Admin message