mtd: rawnand: pasemi: Stop using nand_release() (23cf3461) · Commits · 戴 / test

This helper is not very useful and very often people get confused: they use nand_release() instead of nand_cleanup(). Let's stop using nand_release() by calling mtd_device_unregister() and nand_cleanup() directly. Signed-off-by:

Miquel Raynal <miquel.raynal@bootlin.com> Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-42-miquel.raynal@bootlin.com

drivers/mtd/nand/raw/pasemi_nand.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -169,6 +169,7 @@ static int pasemi_nand_probe(struct platform_device *ofdev)
		static int pasemi_nand_remove(struct platform_device *ofdev)
		{
		struct nand_chip *chip;
		int ret;

		if (!pasemi_nand_mtd)
		return 0;
		@@ -176,7 +177,9 @@ static int pasemi_nand_remove(struct platform_device *ofdev)
		chip = mtd_to_nand(pasemi_nand_mtd);

		/* Release resources, unregister device */
		nand_release(chip);
		ret = mtd_device_unregister(pasemi_nand_mtd);
		WARN_ON(ret);
		nand_cleanup(chip);

		release_region(lpcctl, 4);

Admin message