Commit 23c30108 authored Jan 14, 2011 by Benjamin Marzinski Committed by Steven Whitehouse Jan 18, 2011

GFS2: remove iopen glocks from cache on failed deletes

When a file gets deleted on GFS2, if a node can't get an exclusive lock on the
file's iopen glock, it punts on actually freeing up the space, because another
node is using the file. When it does this, it needs to drop the iopen glock
from its cache so that the other node can get an exclusive lock on it. Now,
gfs2_delete_inode() sets GL_NOCACHE before dropping the shared lock on the
iopen glock in preparation for grabbing it in the exclusive state. Since the
node needs the glock in the exclusive state, dropping the shared lock from the
cache doesn't slow down the case where no other nodes are using the file.

Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>

parent e6f597a1

fs/gfs2/super.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1336,6 +1336,7 @@ static void gfs2_evict_inode(struct inode *inode)
		if (error)
		goto out_truncate;

		ip->i_iopen_gh.gh_flags \|= GL_NOCACHE;
		gfs2_glock_dq_wait(&ip->i_iopen_gh);
		gfs2_holder_reinit(LM_ST_EXCLUSIVE, LM_FLAG_TRY_1CB \| GL_NOCACHE, &ip->i_iopen_gh);
		error = gfs2_glock_nq(&ip->i_iopen_gh);

Admin message