Commit 23954cb0 authored Feb 10, 2020 by Larry Finger Committed by Greg Kroah-Hartman Feb 10, 2020

staging: rtl8723bs: Fix potential overuse of kernel memory



In routine wpa_supplicant_ioctl(), the user-controlled p->length is
checked to be at least the size of struct ieee_param size, but the code
does not detect the case where p->length is greater than the size
of the struct, thus a malicious user could be wasting kernel memory.
Fixes commit 554c0a3a ("staging: Add rtl8723bs sdio wifi driver").

Reported by: Pietro Oliva <pietroliva@gmail.com>
Cc: Pietro Oliva <pietroliva@gmail.com>
Cc: Stable <stable@vger.kernel.org>
Fixes: 554c0a3a ("staging: Add rtl8723bs sdio wifi driver").
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Link: https://lore.kernel.org/r/20200210180235.21691-5-Larry.Finger@lwfinger.net


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 4ddf8ab8

drivers/staging/rtl8723bs/os_dep/ioctl_linux.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -3373,7 +3373,7 @@ static int wpa_supplicant_ioctl(struct net_device dev, struct iw_point p)

	/* down(&ieee->wx_sem); */		/* down(&ieee->wx_sem); */

	if (p->length < sizeof(struct ieee_param) \|\| !p->pointer) {		if (!p->pointer \|\| p->length != sizeof(struct ieee_param)) {
	ret = -EINVAL;		ret = -EINVAL;
	goto out;		goto out;
	}		}

Admin message