vt: keyboard, use find_next_bit in kbd_match (2389cdc3) · Commits · 戴 / test

Instead of a 'for' loop with 'test_bit's to find a bit in a range, use find_next_bit to achieve the same in a simpler and faster manner. Signed-off-by:

Jiri Slaby <jslaby@suse.cz> Link: https://lore.kernel.org/r/20201029113222.32640-16-jslaby@suse.cz Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/tty/vt/keyboard.c

+6 −8

Original line number	Diff line number	Diff line
		@@ -1535,17 +1535,15 @@ static void kbd_event(struct input_handle *handle, unsigned int event_type,

		static bool kbd_match(struct input_handler handler, struct input_dev dev)
		{
		int i;

		if (test_bit(EV_SND, dev->evbit))
		return true;

		if (test_bit(EV_KEY, dev->evbit)) {
		for (i = KEY_RESERVED; i < BTN_MISC; i++)
		if (test_bit(i, dev->keybit))
		if (find_next_bit(dev->keybit, BTN_MISC, KEY_RESERVED) <
		BTN_MISC)
		return true;
		for (i = KEY_BRL_DOT1; i <= KEY_BRL_DOT10; i++)
		if (test_bit(i, dev->keybit))
		if (find_next_bit(dev->keybit, KEY_BRL_DOT10 + 1,
		KEY_BRL_DOT1) <= KEY_BRL_DOT10)
		return true;
		}

Admin message