Commit 238262af authored Jul 12, 2018 by Sean Wang Committed by Linus Walleij Jul 17, 2018

pinctrl: mt7622: Fix probe fail by misuse the selector

After the commit acf137951367 ("pinctrl: core: Return selector to the
pinctrl driver") and the commit 47f1242d19c3 ("pinctrl: pinmux: Return
selector to the pinctrl driver"), it's necessary to add the fixes
needed for the pin controller drivers to use the appropriate returned
selector for a negative error number returned in case of the fail at
these functions. Otherwise, the driver would have a failed probe and
that causes boot message cannot correctly output and devices fail
to acquire their own pins.

Cc: Kevin Hilman <khilman@baylibre.com>
Fixes: acf137951367 ("pinctrl: core: Return selector to the pinctrl driver")
Fixes: 47f1242d19c3 ("pinctrl: pinmux: Return selector to the pinctrl driver")
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 673ba5a0

drivers/pinctrl/mediatek/pinctrl-mt7622.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1525,7 +1525,7 @@ static int mtk_build_groups(struct mtk_pinctrl *hw)
		err = pinctrl_generic_add_group(hw->pctrl, group->name,
		group->pins, group->num_pins,
		group->data);
		if (err) {
		if (err < 0) {
		dev_err(hw->dev, "Failed to register group %s\n",
		group->name);
		return err;
		@@ -1546,7 +1546,7 @@ static int mtk_build_functions(struct mtk_pinctrl *hw)
		func->group_names,
		func->num_group_names,
		func->data);
		if (err) {
		if (err < 0) {
		dev_err(hw->dev, "Failed to register function %s\n",
		func->name);
		return err;

Admin message