Commit 236561e5 authored by Alan Cox's avatar Alan Cox Committed by Linus Torvalds
Browse files

[PATCH] PCI quirks update 



This fixes two things

Firstly someone mistakenly used "errata" for the singular.  This causes
Dave Woodhouse to emit diagnostics whenever the string is read, and so
should be fixed.

Secondly the AMD AGP tunnel has an erratum which causes hangs if you try
and do direct PCI to AGP transfers in some cases.  We have a flag for
PCI/PCI failures but we need a different flag for this really as in this
case we don't want to stop PCI/PCI transfers using things like IOAT and the
new RAID offload work.

I'll post some updates to make proper use of the PCIAGP flag in the
media/video drivers to Mauro.

Signed-off-by: default avatarAlan Cox <alan@redhat.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 3fcd03e0

drivers/pci/quirks.c

+15 −2
Original line number Diff line number Diff line
@@ -93,8 +93,21 @@ static void __devinit quirk_nopcipci(struct pci_dev *dev) 
		pci_pci_problems |= PCIPCI_FAIL;

	}

}



static void __devinit quirk_nopciamd(struct pci_dev *dev)

{

	u8 rev;

	pci_read_config_byte(dev, 0x08, &rev);

	if (rev == 0x13) {

		/* Erratum 24 */

		printk(KERN_INFO "Chipset erratum: Disabling direct PCI/AGP transfers.\n");

		pci_pci_problems |= PCIAGP_FAIL;

	}

}



DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_SI,	PCI_DEVICE_ID_SI_5597,		quirk_nopcipci );

DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_SI,	PCI_DEVICE_ID_SI_496,		quirk_nopcipci );

DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD,	PCI_DEVICE_ID_AMD_8151_0,	quirk_nopciamd );



/*

 *	Triton requires workarounds to be used by the drivers
@@ -555,7 +568,7 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_8237, quirk_via_vt 
 * is currently marked NoFix

 *

 * We have multiple reports of hangs with this chipset that went away with

 * noapic specified. For the moment we assume its the errata. We may be wrong

 * noapic specified. For the moment we assume it's the erratum. We may be wrong

 * of course. However the advice is demonstrably good even if so..

 */

static void __devinit quirk_amd_ioapic(struct pci_dev *dev)
@@ -564,7 +577,7 @@ static void __devinit quirk_amd_ioapic(struct pci_dev *dev) 


	pci_read_config_byte(dev, PCI_REVISION_ID, &rev);

	if (rev >= 0x02) {

		printk(KERN_WARNING "I/O APIC: AMD Errata #22 may be present. In the event of instability try\n");

		printk(KERN_WARNING "I/O APIC: AMD Erratum #22 may be present. In the event of instability try\n");

		printk(KERN_WARNING "        : booting with the \"noapic\" option.\n");

	}

}

include/linux/pci.h

+3 −2
Original line number Diff line number Diff line
@@ -787,12 +787,13 @@ enum pci_fixup_pass { 
void pci_fixup_device(enum pci_fixup_pass pass, struct pci_dev *dev);



extern int pci_pci_problems;

#define PCIPCI_FAIL		1

#define PCIPCI_FAIL		1	/* No PCI PCI DMA */

#define PCIPCI_TRITON		2

#define PCIPCI_NATOMA		4

#define PCIPCI_VIAETBF		8

#define PCIPCI_VSFX		16

#define PCIPCI_ALIMAGIK		32

#define PCIPCI_ALIMAGIK		32	/* Need low latency setting */

#define PCIAGP_FAIL		64	/* No PCI to AGP DMA */



#endif /* __KERNEL__ */

#endif /* LINUX_PCI_H */

CRA Git | Maintained and supported by SUSTech CRA and CCSE