gpio: clamp returned values to the boolean range (23600969) · Commits · 戴 / test

Nothing prevents GPIO drivers from returning values outside the boolean range, and as it turns out a few drivers are actually doing so. These values were passed as-is to unsuspecting consumers and created confusion. This patch makes the internal _gpiod_get_raw_value() function return a bool, effectively clamping the GPIO value to the boolean range no matter what the driver does. While we are at it, we also change the value parameter of _gpiod_set_raw_value() to bool type before drivers start doing funny things with it as well. Another way to fix this would be to change the prototypes of the driver interface to use bool directly, but this would require a huge cross-systems patch so this simpler solution is preferred. Changes since v1: - Change local variable type to bool as well, use boolean values in code - Also change prototype of open drain/open source setting functions since they are only called from _gpiod_set_raw_value() This probably calls for a larger booleanization of gpiolib, but let's keep that for a latter change - right now we need to address the issue of non-boolean values returned by drivers. Signed-off-by:

Alexandre Courbot <acourbot@nvidia.com> Signed-off-by:

Linus Walleij <linus.walleij@linaro.org>

drivers/gpio/gpiolib.c

+6 −6

Original line number	Diff line number	Diff line
		@@ -2005,15 +2005,15 @@ EXPORT_SYMBOL_GPL(gpiod_is_active_low);
		* that the GPIO was actually requested.
		*/

		static int _gpiod_get_raw_value(const struct gpio_desc *desc)
		static bool _gpiod_get_raw_value(const struct gpio_desc *desc)
		{
		struct gpio_chip *chip;
		int value;
		bool value;
		int offset;

		chip = desc->chip;
		offset = gpio_chip_hwgpio(desc);
		value = chip->get ? chip->get(chip, offset) : 0;
		value = chip->get ? chip->get(chip, offset) : false;
		trace_gpio_value(desc_to_gpio(desc), 1, value);
		return value;
		}
		@@ -2069,7 +2069,7 @@ EXPORT_SYMBOL_GPL(gpiod_get_value);
		* @desc: gpio descriptor whose state need to be set.
		* @value: Non-zero for setting it HIGH otherise it will set to LOW.
		*/
		static void _gpio_set_open_drain_value(struct gpio_desc *desc, int value)
		static void _gpio_set_open_drain_value(struct gpio_desc *desc, bool value)
		{
		int err = 0;
		struct gpio_chip *chip = desc->chip;
		@@ -2096,7 +2096,7 @@ static void _gpio_set_open_drain_value(struct gpio_desc *desc, int value)
		* @desc: gpio descriptor whose state need to be set.
		* @value: Non-zero for setting it HIGH otherise it will set to LOW.
		*/
		static void _gpio_set_open_source_value(struct gpio_desc *desc, int value)
		static void _gpio_set_open_source_value(struct gpio_desc *desc, bool value)
		{
		int err = 0;
		struct gpio_chip *chip = desc->chip;
		@@ -2118,7 +2118,7 @@ static void _gpio_set_open_source_value(struct gpio_desc *desc, int value)
		__func__, err);
		}

		static void _gpiod_set_raw_value(struct gpio_desc *desc, int value)
		static void _gpiod_set_raw_value(struct gpio_desc *desc, bool value)
		{
		struct gpio_chip *chip;

Admin message