Commit 23520b2d authored Feb 21, 2020 by Miaohe Lin Committed by Paolo Bonzini Feb 21, 2020

KVM: apic: avoid calculating pending eoi from an uninitialized val



When pv_eoi_get_user() fails, 'val' may remain uninitialized and the return
value of pv_eoi_get_pending() becomes random. Fix the issue by initializing
the variable.

Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Cc: stable@vger.kernel.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

parent a4443267

arch/x86/kvm/lapic.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -627,9 +627,11 @@ static inline bool pv_eoi_enabled(struct kvm_vcpu *vcpu)
		static bool pv_eoi_get_pending(struct kvm_vcpu *vcpu)
		{
		u8 val;
		if (pv_eoi_get_user(vcpu, &val) < 0)
		if (pv_eoi_get_user(vcpu, &val) < 0) {
		printk(KERN_WARNING "Can't read EOI MSR value: 0x%llx\n",
		(unsigned long long)vcpu->arch.pv_eoi.msr_val);
		return false;
		}
		return val & 0x1;
		}

Admin message