Commit 233c6378 authored Aug 26, 2020 by Ido Schimmel Committed by David S. Miller Aug 26, 2020

ipv4: nexthop: Remove unnecessary rtnl_dereference()



The pointer is not RCU protected, so remove the unnecessary
rtnl_dereference(). This suppresses the following warning:

net/ipv4/nexthop.c:1101:24: error: incompatible types in comparison expression (different address spaces):
net/ipv4/nexthop.c:1101:24:    struct rb_node [noderef] __rcu *
net/ipv4/nexthop.c:1101:24:    struct rb_node *

Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 33d80996

net/ipv4/nexthop.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1098,7 +1098,7 @@ static int insert_nexthop(struct net net, struct nexthop new_nh,
		while (1) {
		struct nexthop *nh;

		next = rtnl_dereference(*pp);
		next = *pp;
		if (!next)
		break;

Admin message