infiniband: hfi1: fix memory leaks (2323d7ba) · Commits · 戴 / test

In fault_opcodes_write(), 'data' is allocated through kcalloc(). However, it is not deallocated in the following execution if an error occurs, leading to memory leaks. To fix this issue, introduce the 'free_data' label to free 'data' before returning the error. Signed-off-by:

Wenwen Wang <wenwen@cs.uga.edu> Reviewed-by:

Leon Romanovsky <leonro@mellanox.com> Acked-by:

Dennis Dalessandro <dennis.dalessandro@intel.com> Link: https://lore.kernel.org/r/1566154486-3713-1-git-send-email-wenwen@cs.uga.edu Signed-off-by:

Doug Ledford <dledford@redhat.com>

drivers/infiniband/hw/hfi1/fault.c

+6 −3

Original line number	Diff line number	Diff line
		@@ -141,12 +141,14 @@ static ssize_t fault_opcodes_write(struct file file, const char __user buf,
		if (!data)
		return -ENOMEM;
		copy = min(len, datalen - 1);
		if (copy_from_user(data, buf, copy))
		return -EFAULT;
		if (copy_from_user(data, buf, copy)) {
		ret = -EFAULT;
		goto free_data;
		}

		ret = debugfs_file_get(file->f_path.dentry);
		if (unlikely(ret))
		return ret;
		goto free_data;
		ptr = data;
		token = ptr;
		for (ptr = data; *ptr; ptr = end + 1, token = ptr) {
		@@ -195,6 +197,7 @@ static ssize_t fault_opcodes_write(struct file file, const char __user buf,
		ret = len;

		debugfs_file_put(file->f_path.dentry);
		free_data:
		kfree(data);
		return ret;
		}

Admin message