rsi: return explicit error values (231e83fd) · Commits · 戴 / test

Explicitly return constants instead of variable (and rely on it to be explicitly initialized), if the value is supposed to be fixed anyways. Align it with the rest of the driver, which does it the same way. Signed-off-by:

Enrico Weigelt <info@metux.net> Signed-off-by:

Kalle Valo <kvalo@codeaurora.org>

drivers/net/wireless/rsi/rsi_91x_sdio.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -844,11 +844,11 @@ static int rsi_init_sdio_interface(struct rsi_hw *adapter,
		struct sdio_func *pfunction)
		{
		struct rsi_91x_sdiodev *rsi_91x_dev;
		int status = -ENOMEM;
		int status;

		rsi_91x_dev = kzalloc(sizeof(*rsi_91x_dev), GFP_KERNEL);
		if (!rsi_91x_dev)
		return status;
		return -ENOMEM;

		adapter->rsi_dev = rsi_91x_dev;

		@@ -890,7 +890,7 @@ static int rsi_init_sdio_interface(struct rsi_hw *adapter,
		#ifdef CONFIG_RSI_DEBUGFS
		adapter->num_debugfs_entries = MAX_DEBUGFS_ENTRIES;
		#endif
		return status;
		return 0;
		fail:
		sdio_disable_func(pfunction);
		sdio_release_host(pfunction);

Admin message