Commit 231b85ab authored Mar 11, 2018 by Ido Schimmel Committed by David S. Miller Mar 11, 2018

selftests: forwarding: Exit with error when missing interfaces



Returning 0 gives a false sense of success when the required modules did
not even manage to be initialized and register the required net devices.

Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Reviewed-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent ff0162af

tools/testing/selftests/net/forwarding/lib.sh

+2 −2

Original line number	Diff line number	Diff line
		@@ -55,7 +55,7 @@ fi

		if [[ ! -v NUM_NETIFS ]]; then
		echo "SKIP: importer does not define \"NUM_NETIFS\""
		exit 0
		exit 1
		fi

		##############################################################################
		@@ -115,7 +115,7 @@ for i in $(eval echo {1..$NUM_NETIFS}); do
		ip link show dev ${NETIFS[p$i]} &> /dev/null
		if [[ $? -ne 0 ]]; then
		echo "SKIP: could not find all required interfaces"
		exit 0
		exit 1
		fi
		done

Admin message