Commit 2316380f authored by Sara Sharon's avatar Sara Sharon Committed by Johannes Berg
Browse files

mac80211: call synchronize_net once in the restart flow 



Currently the restart flow enables RX back, and then proceeds
to tear down RX and TX aggregations.
The TX aggregation tear down calls synchronize_net(), which
waits for packet receiving to be done.
This is done for every session, while RX processing is already
active, and in some reproductions it takes up to 3 seconds.
Add a call once in the restart_work, before we have traffic
active again, and remove the subsequent calls when tearing
down the aggregation.
This requires to move down the code that turns off the
reconfig flag in order to be able to test it in
_ieee80211_stop_tx_ba_session().

Signed-off-by: default avatarSara Sharon <sara.sharon@intel.com>
Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 9fef6544

net/mac80211/agg-tx.c

+2 −1
Original line number Diff line number Diff line
@@ -392,6 +392,7 @@ int ___ieee80211_stop_tx_ba_session(struct sta_info *sta, u16 tid, 
	 * telling the driver. New packets will not go through since

	 * the aggregation session is no longer OPERATIONAL.

	 */

	if (!local->in_reconfig)

		synchronize_net();



	tid_tx->stop_initiator = reason == AGG_STOP_PEER_REQUEST ?

net/mac80211/main.c

+3 −0
Original line number Diff line number Diff line
@@ -263,6 +263,9 @@ static void ieee80211_restart_work(struct work_struct *work) 
	flush_delayed_work(&local->roc_work);

	flush_work(&local->hw_roc_done);



	/* wait for all packet processing to be done */

	synchronize_net();



	ieee80211_reconfig(local);

	rtnl_unlock();

}

net/mac80211/util.c

+10 −9
Original line number Diff line number Diff line
@@ -2110,15 +2110,6 @@ int ieee80211_reconfig(struct ieee80211_local *local) 
		cfg80211_sched_scan_stopped_rtnl(local->hw.wiphy, 0);



 wake_up:

	if (local->in_reconfig) {

		local->in_reconfig = false;

		barrier();



		/* Restart deferred ROCs */

		mutex_lock(&local->mtx);

		ieee80211_start_next_roc(local);

		mutex_unlock(&local->mtx);

	}



	if (local->monitors == local->open_count && local->monitors > 0)

		ieee80211_add_virtual_monitor(local);
@@ -2146,6 +2137,16 @@ int ieee80211_reconfig(struct ieee80211_local *local) 
		mutex_unlock(&local->sta_mtx);

	}



	if (local->in_reconfig) {

		local->in_reconfig = false;

		barrier();



		/* Restart deferred ROCs */

		mutex_lock(&local->mtx);

		ieee80211_start_next_roc(local);

		mutex_unlock(&local->mtx);

	}



	ieee80211_wake_queues_by_reason(hw, IEEE80211_MAX_QUEUE_MAP,

					IEEE80211_QUEUE_STOP_REASON_SUSPEND,

					false);

CRA Git | Maintained and supported by SUSTech CRA and CCSE