Commit 230a1bc2 authored Apr 03, 2020 by Parav Pandit Committed by Saeed Mahameed Apr 08, 2020

net/mlx5e: Fix devlink port netdev unregistration sequence



In cited commit netdevice is registered after devlink port.

Unregistration flow should be mirror sequence of registration flow.
Hence, unregister netdevice before devlink port.

Fixes: 31e87b39 ("net/mlx5e: Fix devlink port register sequence")
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: Parav Pandit <parav@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>

parent 7482d9cb

drivers/net/ethernet/mellanox/mlx5/core/en_main.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -5526,8 +5526,8 @@ static void mlx5e_remove(struct mlx5_core_dev mdev, void vpriv)
		#ifdef CONFIG_MLX5_CORE_EN_DCB
		mlx5e_dcbnl_delete_app(priv);
		#endif
		mlx5e_devlink_port_unregister(priv);
		unregister_netdev(priv->netdev);
		mlx5e_devlink_port_unregister(priv);
		mlx5e_detach(mdev, vpriv);
		mlx5e_destroy_netdev(priv);
		}

Admin message