Commit 22feda47 authored Mar 18, 2019 by Gustavo A. R. Silva Committed by Greg Kroah-Hartman Mar 19, 2019

usb: usb251xb: Remove unnecessary comparison of unsigned integer with >= 0



There is no need to compare *port* with >= 0 because such comparison
of an unsigned value is always true.

Fix this by removing such comparison.

Addresses-Coverity-ID: 1443949 ("Unsigned compared against 0")
Fixes: 02a50b87 ("usb: usb251xb: add usb data lane port swap feature")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Richard Leitner <richard.leitner@skidata.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 238e0268

drivers/usb/misc/usb251xb.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -547,7 +547,7 @@ static int usb251xb_get_ofdata(struct usb251xb *hub,
	*/		*/
	hub->port_swap = USB251XB_DEF_PORT_SWAP;		hub->port_swap = USB251XB_DEF_PORT_SWAP;
	of_property_for_each_u32(np, "swap-dx-lanes", prop, p, port) {		of_property_for_each_u32(np, "swap-dx-lanes", prop, p, port) {
	if ((port >= 0) && (port <= data->port_cnt))		if (port <= data->port_cnt)
	hub->port_swap \|= BIT(port);		hub->port_swap \|= BIT(port);
	}		}

Admin message