Commit 22fecdf5 authored Jul 28, 2016 by Mel Gorman Committed by Linus Torvalds Jul 28, 2016

mm, vmscan: remove redundant check in shrink_zones()

As pointed out by Minchan Kim, shrink_zones() checks for populated zones
in a zonelist but a zonelist can never contain unpopulated zones.  While
it's not related to the node-lru series, it can be cleaned up now.

Link: http://lkml.kernel.org/r/1468853426-12858-2-git-send-email-mgorman@techsingularity.net


Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
Suggested-by: Minchan Kim <minchan@kernel.org>
Acked-by: Minchan Kim <minchan@kernel.org>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 7ee36a14

mm/vmscan.c

+0 −3

Original line number	Original line	Diff line number	Diff line
	@@ -2605,9 +2605,6 @@ static void shrink_zones(struct zonelist zonelist, struct scan_control sc)

	for_each_zone_zonelist_nodemask(zone, z, zonelist,		for_each_zone_zonelist_nodemask(zone, z, zonelist,
	sc->reclaim_idx, sc->nodemask) {		sc->reclaim_idx, sc->nodemask) {
	if (!populated_zone(zone))
	continue;

	/*		/*
	* Take care memory controller reclaiming has small influence		* Take care memory controller reclaiming has small influence
	* to global LRU.		* to global LRU.

Admin message