Commit 22f8d5a1 authored Jun 20, 2020 by Huacai Chen Committed by Alexandre Belloni Jul 16, 2020

rtc: goldfish: Enable interrupt in set_alarm() when necessary



When use goldfish rtc, the "hwclock" command fails with "select() to
/dev/rtc to wait for clock tick timed out". This is because "hwclock"
need the set_alarm() hook to enable interrupt when alrm->enabled is
true. This operation is missing in goldfish rtc (but other rtc drivers,
such as cmos rtc, enable interrupt here), so add it.

Signed-off-by: Huacai Chen <chenhc@lemote.com>
Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/1592654683-31314-1-git-send-email-chenhc@lemote.com

parent d8f090db

drivers/rtc/rtc-goldfish.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -73,6 +73,7 @@ static int goldfish_rtc_set_alarm(struct device *dev,
		rtc_alarm64 = rtc_tm_to_time64(&alrm->time) * NSEC_PER_SEC;
		writel((rtc_alarm64 >> 32), base + TIMER_ALARM_HIGH);
		writel(rtc_alarm64, base + TIMER_ALARM_LOW);
		writel(1, base + TIMER_IRQ_ENABLED);
		} else {
		/*
		* if this function was called with enabled=0

Admin message