Commit 22f60701 authored by Linus Torvalds's avatar Linus Torvalds
Browse files

Merge tag 'pm+acpi-4.5-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm 

Pull power management and ACPI fixes from Rafael Wysocki:
 "These are: a fix for a recently introduced false-positive warnings
  about PM domain pointers being changed inappropriately (harmless but
  annoying), an MCH size workaround quirk for one more platform, a
  compiler warning fix (generic power domains framework), an ACPI LPSS
  (Intel SoCs) driver fixup and a cleanup of the ACPI CPPC core code.

  Specifics:

   - PM core fix to avoid false-positive warnings generated when the
     pm_domain field is cleared for a device that appears to be bound to
     a driver (Rafael Wysocki).

   - New MCH size workaround quirk for Intel Haswell-ULT (Josh Boyer).

   - Fix for an "unused function" compiler warning in the generic power
     domains framework (Ulf Hansson).

   - Fixup for the ACPI driver for Intel SoCs (acpi-lpss) to set the PM
     domain pointer of a device properly in one place that was
     overlooked by a recent PM core update (Andy Shevchenko).

   - Removal of a redundant function declaration in the ACPI CPPC core
     code (Timur Tabi)"

* tag 'pm+acpi-4.5-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm:
  PM: Avoid false-positive warnings in dev_pm_domain_set()
  PM / Domains: Silence compiler warning for an unused function
  ACPI / CPPC: remove redundant mbox_send_message() declaration
  ACPI / LPSS: set PM domain via helper setter
  PNP: Add Haswell-ULT to Intel MCH size workaround
parents dd6f86af 79e2f8dd

drivers/acpi/acpi_lpss.c

+1 −1
Original line number Diff line number Diff line
@@ -880,7 +880,7 @@ static int acpi_lpss_platform_notify(struct notifier_block *nb, 
		break;

	case BUS_NOTIFY_DRIVER_NOT_BOUND:

	case BUS_NOTIFY_UNBOUND_DRIVER:

		pdev->dev.pm_domain = NULL;

		dev_pm_domain_set(&pdev->dev, NULL);

		break;

	case BUS_NOTIFY_ADD_DEVICE:

		dev_pm_domain_set(&pdev->dev, &acpi_lpss_pm_domain);

drivers/base/power/common.c

+1 −1
Original line number Diff line number Diff line
@@ -146,7 +146,7 @@ void dev_pm_domain_set(struct device *dev, struct dev_pm_domain *pd) 
	if (dev->pm_domain == pd)

		return;



	WARN(device_is_bound(dev),

	WARN(pd && device_is_bound(dev),

	     "PM domains can only be changed for unbound devices\n");

	dev->pm_domain = pd;

	device_pm_check_callbacks(dev);

drivers/base/power/domain.c

+7 −20
Original line number Diff line number Diff line
@@ -173,14 +173,14 @@ static void genpd_queue_power_off_work(struct generic_pm_domain *genpd) 
}



/**

 * __genpd_poweron - Restore power to a given PM domain and its masters.

 * genpd_poweron - Restore power to a given PM domain and its masters.

 * @genpd: PM domain to power up.

 * @depth: nesting count for lockdep.

 *

 * Restore power to @genpd and all of its masters so that it is possible to

 * resume a device belonging to it.

 */

static int __genpd_poweron(struct generic_pm_domain *genpd, unsigned int depth)

static int genpd_poweron(struct generic_pm_domain *genpd, unsigned int depth)

{

	struct gpd_link *link;

	int ret = 0;
@@ -200,7 +200,7 @@ static int __genpd_poweron(struct generic_pm_domain *genpd, unsigned int depth) 
		genpd_sd_counter_inc(master);



		mutex_lock_nested(&master->lock, depth + 1);

		ret = __genpd_poweron(master, depth + 1);

		ret = genpd_poweron(master, depth + 1);

		mutex_unlock(&master->lock);



		if (ret) {
@@ -227,21 +227,6 @@ static int __genpd_poweron(struct generic_pm_domain *genpd, unsigned int depth) 
	return ret;

}



/**

 * genpd_poweron - Restore power to a given PM domain and its masters.

 * @genpd: PM domain to power up.

 */

static int genpd_poweron(struct generic_pm_domain *genpd)

{

	int ret;



	mutex_lock(&genpd->lock);

	ret = __genpd_poweron(genpd, 0);

	mutex_unlock(&genpd->lock);

	return ret;

}





static int genpd_save_dev(struct generic_pm_domain *genpd, struct device *dev)

{

	return GENPD_DEV_CALLBACK(genpd, int, save_state, dev);
@@ -489,7 +474,7 @@ static int pm_genpd_runtime_resume(struct device *dev) 
	}



	mutex_lock(&genpd->lock);

	ret = __genpd_poweron(genpd, 0);

	ret = genpd_poweron(genpd, 0);

	mutex_unlock(&genpd->lock);



	if (ret)
@@ -1821,8 +1806,10 @@ int genpd_dev_pm_attach(struct device *dev) 


	dev->pm_domain->detach = genpd_dev_pm_detach;

	dev->pm_domain->sync = genpd_dev_pm_sync;

	ret = genpd_poweron(pd);



	mutex_lock(&pd->lock);

	ret = genpd_poweron(pd, 0);

	mutex_unlock(&pd->lock);

out:

	return ret ? -EPROBE_DEFER : 0;

}

drivers/pnp/quirks.c

+1 −0
Original line number Diff line number Diff line
@@ -342,6 +342,7 @@ static void quirk_amd_mmconfig_area(struct pnp_dev *dev) 
/* Device IDs of parts that have 32KB MCH space */

static const unsigned int mch_quirk_devices[] = {

	0x0154,	/* Ivy Bridge */

	0x0a04, /* Haswell-ULT */

	0x0c00,	/* Haswell */

	0x1604, /* Broadwell */

};

include/acpi/cppc_acpi.h

+0 −1
Original line number Diff line number Diff line
@@ -133,6 +133,5 @@ extern int acpi_get_psd_map(struct cpudata **); 
/* Methods to interact with the PCC mailbox controller. */

extern struct mbox_chan *

	pcc_mbox_request_channel(struct mbox_client *, unsigned int);

extern int mbox_send_message(struct mbox_chan *chan, void *mssg);



#endif /* _CPPC_ACPI_H*/

CRA Git | Maintained and supported by SUSTech CRA and CCSE