Commit 22ec0808 authored by Steve Longerbeam's avatar Steve Longerbeam Committed by Philipp Zabel
Browse files

gpu: ipu-cpmem: add WARN_ON_ONCE() for unaligned dma buffers 



Add a WARN_ON_ONCE() if either the Y/packed buffer, or the U/V offsets,
are not aligned on 8-byte boundaries. This will catch alignment
bugs in DRM, V4L2.

Signed-off-by: default avatarSteve Longerbeam <slongerbeam@gmail.com>
Tested-by: default avatarPhilipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: default avatarPhilipp Zabel <p.zabel@pengutronix.de>
parent fac8033f

drivers/gpu/ipu-v3/ipu-cpmem.c

+6 −0
Original line number Diff line number Diff line
@@ -259,6 +259,8 @@ EXPORT_SYMBOL_GPL(ipu_cpmem_set_high_priority); 


void ipu_cpmem_set_buffer(struct ipuv3_channel *ch, int bufnum, dma_addr_t buf)

{

	WARN_ON_ONCE(buf & 0x7);



	if (bufnum)

		ipu_ch_param_write_field(ch, IPU_FIELD_EBA1, buf >> 3);

	else
@@ -268,6 +270,8 @@ EXPORT_SYMBOL_GPL(ipu_cpmem_set_buffer); 


void ipu_cpmem_set_uv_offset(struct ipuv3_channel *ch, u32 u_off, u32 v_off)

{

	WARN_ON_ONCE((u_off & 0x7) || (v_off & 0x7));



	ipu_ch_param_write_field(ch, IPU_FIELD_UBO, u_off / 8);

	ipu_ch_param_write_field(ch, IPU_FIELD_VBO, v_off / 8);

}
@@ -435,6 +439,8 @@ void ipu_cpmem_set_yuv_planar_full(struct ipuv3_channel *ch, 
				   unsigned int uv_stride,

				   unsigned int u_offset, unsigned int v_offset)

{

	WARN_ON_ONCE((u_offset & 0x7) || (v_offset & 0x7));



	ipu_ch_param_write_field(ch, IPU_FIELD_SLUV, uv_stride - 1);

	ipu_ch_param_write_field(ch, IPU_FIELD_UBO, u_offset / 8);

	ipu_ch_param_write_field(ch, IPU_FIELD_VBO, v_offset / 8);

CRA Git | Maintained and supported by SUSTech CRA and CCSE