Commit 22dd1491 authored Jul 06, 2018 by Arnd Bergmann Committed by David S. Miller Jul 07, 2018

devlink: fix incorrect return statement



A newly added dummy helper function tries to return a failure from a "void"
function:

In file included from include/net/dsa.h:24,
                 from arch/arm/plat-orion/common.c:21:
include/net/devlink.h: In function 'devlink_param_value_changed':
include/net/devlink.h:771:9: error: 'return' with a value, in function returning void [-Werror]
  return -EOPNOTSUPP;

This fixes it by removing the bogus statement.

Fixes: ea601e17 ("devlink: Add devlink notifications support for params")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent be9c64b1

include/net/devlink.h

+0 −1

Original line number	Diff line number	Diff line
		@@ -768,7 +768,6 @@ devlink_param_driverinit_value_set(struct devlink *devlink, u32 param_id,
		static inline void
		devlink_param_value_changed(struct devlink *devlink, u32 param_id)
		{
		return -EOPNOTSUPP;
		}

		#endif

Admin message