gpio: wcove: Request IRQ after all initialisation done (22cc4220) · Commits · 戴 / test

There is logically better to request IRQ when we initialise all structures. Align the driver with the rest on the same matter. Signed-off-by:

drivers/gpio/gpio-wcove.c

+7 −7

Original line number	Diff line number	Diff line
		@@ -449,13 +449,6 @@ static int wcove_gpio_probe(struct platform_device *pdev)
		return virq;
		}

		ret = devm_request_threaded_irq(dev, virq, NULL,
		wcove_gpio_irq_handler, IRQF_ONESHOT, pdev->name, wg);
		if (ret) {
		dev_err(dev, "Failed to request irq %d\n", virq);
		return ret;
		}

		girq = &wg->chip.irq;
		girq->chip = &wcove_irqchip;
		/* This will let us handle the parent IRQ in the driver */
		@@ -466,6 +459,13 @@ static int wcove_gpio_probe(struct platform_device *pdev)
		girq->handler = handle_simple_irq;
		girq->threaded = true;

		ret = devm_request_threaded_irq(dev, virq, NULL, wcove_gpio_irq_handler,
		IRQF_ONESHOT, pdev->name, wg);
		if (ret) {
		dev_err(dev, "Failed to request irq %d\n", virq);
		return ret;
		}

		ret = devm_gpiochip_add_data(dev, &wg->chip, wg);
		if (ret) {
		dev_err(dev, "Failed to add gpiochip: %d\n", ret);