Commit 22a8118d authored Oct 07, 2018 by Michael Schupikov Committed by Herbert Xu Oct 12, 2018

crypto: testmgr - fix sizeof() on COMP_BUF_SIZE



After allocation, output and decomp_output both point to memory chunks of
size COMP_BUF_SIZE. Then, only the first bytes are zeroed out using
sizeof(COMP_BUF_SIZE) as parameter to memset(), because
sizeof(COMP_BUF_SIZE) provides the size of the constant and not the size of
allocated memory.

Instead, the whole allocated memory is meant to be zeroed out. Use
COMP_BUF_SIZE as parameter to memset() directly in order to accomplish
this.

Fixes: 33607384 ("crypto: testmgr - Allow different compression results")

Signed-off-by: Michael Schupikov <michael@schupikov.de>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent cb1af1f5

crypto/testmgr.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -1400,8 +1400,8 @@ static int test_comp(struct crypto_comp *tfm,
		int ilen;
		unsigned int dlen = COMP_BUF_SIZE;

		memset(output, 0, sizeof(COMP_BUF_SIZE));
		memset(decomp_output, 0, sizeof(COMP_BUF_SIZE));
		memset(output, 0, COMP_BUF_SIZE);
		memset(decomp_output, 0, COMP_BUF_SIZE);

		ilen = ctemplate[i].inlen;
		ret = crypto_comp_compress(tfm, ctemplate[i].input,
		@@ -1445,7 +1445,7 @@ static int test_comp(struct crypto_comp *tfm,
		int ilen;
		unsigned int dlen = COMP_BUF_SIZE;

		memset(decomp_output, 0, sizeof(COMP_BUF_SIZE));
		memset(decomp_output, 0, COMP_BUF_SIZE);

		ilen = dtemplate[i].inlen;
		ret = crypto_comp_decompress(tfm, dtemplate[i].input,

Admin message