Commit 227f33be authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

mdio-sun4i: oops in error handling in probe 



We could end up dereferencing an error pointer when we call
regulator_disable().

Fixes: 4bdcb1dd ('net: Add MDIO bus driver for the Allwinner EMAC')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarChen-Yu Tsai <wens@csie.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent abc34d75

drivers/net/phy/mdio-sun4i.c

+3 −1
Original line number Diff line number Diff line
@@ -122,6 +122,7 @@ static int sun4i_mdio_probe(struct platform_device *pdev) 
			return -EPROBE_DEFER;



		dev_info(&pdev->dev, "no regulator found\n");

		data->regulator = NULL;

	} else {

		ret = regulator_enable(data->regulator);

		if (ret)
@@ -137,6 +138,7 @@ static int sun4i_mdio_probe(struct platform_device *pdev) 
	return 0;



err_out_disable_regulator:

	if (data->regulator)

		regulator_disable(data->regulator);

err_out_free_mdiobus:

	mdiobus_free(bus);

CRA Git | Maintained and supported by SUSTech CRA and CCSE