Commit 2278f6cc authored by Willem de Bruijn's avatar Willem de Bruijn Committed by Alexei Starovoitov
Browse files

bpf: add bpf_skb_adjust_room flag BPF_F_ADJ_ROOM_FIXED_GSO 

bpf_skb_adjust_room adjusts gso_size of gso packets to account for the
pushed or popped header room.

This is not allowed with UDP, where gso_size delineates datagrams. Add
an option to avoid these updates and allow this call for datagrams.

It can also be used with TCP, when MSS is known to allow headroom,
e.g., through MSS clamping or route MTU.

Changes v1->v2:
  - document flag BPF_F_ADJ_ROOM_FIXED_GSO
  - do not expose BPF_F_ADJ_ROOM_MASK through uapi, as it may change.

Link: https://patchwork.ozlabs.org/patch/1052497/


Signed-off-by: default avatarWillem de Bruijn <willemb@google.com>
Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
parent 14aa3192

include/uapi/linux/bpf.h

+7 −2
Original line number Diff line number Diff line
@@ -1486,8 +1486,10 @@ union bpf_attr { 
 * 		* **BPF_ADJ_ROOM_NET**: Adjust room at the network layer

 * 		  (room space is added or removed below the layer 3 header).

 *

 * 		All values for *flags* are reserved for future usage, and must

 * 		be left at zero.

 *		There is one supported flag at this time:

 *

 *		* **BPF_F_ADJ_ROOM_FIXED_GSO**: Do not adjust gso_size.

 *		  Adjusting mss in this way is not allowed for datagrams.

 *

 * 		A call to this helper is susceptible to change the underlaying

 * 		packet buffer. Therefore, at load time, all checks on pointers
@@ -2627,6 +2629,9 @@ enum bpf_func_id { 
/* Current network namespace */

#define BPF_F_CURRENT_NETNS		(-1L)



/* BPF_FUNC_skb_adjust_room flags. */

#define BPF_F_ADJ_ROOM_FIXED_GSO	(1ULL << 0)



/* Mode for BPF_FUNC_skb_adjust_room helper. */

enum bpf_adj_room_mode {

	BPF_ADJ_ROOM_NET,

net/core/filter.c

+27 −11
Original line number Diff line number Diff line
@@ -2963,12 +2963,19 @@ static u32 bpf_skb_net_base_len(const struct sk_buff *skb) 
	}

}



static int bpf_skb_net_grow(struct sk_buff *skb, u32 off, u32 len_diff)

#define BPF_F_ADJ_ROOM_MASK		(BPF_F_ADJ_ROOM_FIXED_GSO)



static int bpf_skb_net_grow(struct sk_buff *skb, u32 off, u32 len_diff,

			    u64 flags)

{

	int ret;



	if (skb_is_gso(skb) && !skb_is_gso_tcp(skb))

	if (skb_is_gso(skb) && !skb_is_gso_tcp(skb)) {

		/* udp gso_size delineates datagrams, only allow if fixed */

		if (!(skb_shinfo(skb)->gso_type & SKB_GSO_UDP_L4) ||

		    !(flags & BPF_F_ADJ_ROOM_FIXED_GSO))

			return -ENOTSUPP;

	}



	ret = skb_cow_head(skb, len_diff);

	if (unlikely(ret < 0))
@@ -2982,7 +2989,9 @@ static int bpf_skb_net_grow(struct sk_buff *skb, u32 off, u32 len_diff) 
		struct skb_shared_info *shinfo = skb_shinfo(skb);



		/* Due to header grow, MSS needs to be downgraded. */

		if (!(flags & BPF_F_ADJ_ROOM_FIXED_GSO))

			skb_decrease_gso_size(shinfo, len_diff);



		/* Header must be checked, and gso_segs recomputed. */

		shinfo->gso_type |= SKB_GSO_DODGY;

		shinfo->gso_segs = 0;
@@ -2991,12 +3000,17 @@ static int bpf_skb_net_grow(struct sk_buff *skb, u32 off, u32 len_diff) 
	return 0;

}



static int bpf_skb_net_shrink(struct sk_buff *skb, u32 off, u32 len_diff)

static int bpf_skb_net_shrink(struct sk_buff *skb, u32 off, u32 len_diff,

			      u64 flags)

{

	int ret;



	if (skb_is_gso(skb) && !skb_is_gso_tcp(skb))

	if (skb_is_gso(skb) && !skb_is_gso_tcp(skb)) {

		/* udp gso_size delineates datagrams, only allow if fixed */

		if (!(skb_shinfo(skb)->gso_type & SKB_GSO_UDP_L4) ||

		    !(flags & BPF_F_ADJ_ROOM_FIXED_GSO))

			return -ENOTSUPP;

	}



	ret = skb_unclone(skb, GFP_ATOMIC);

	if (unlikely(ret < 0))
@@ -3010,7 +3024,9 @@ static int bpf_skb_net_shrink(struct sk_buff *skb, u32 off, u32 len_diff) 
		struct skb_shared_info *shinfo = skb_shinfo(skb);



		/* Due to header shrink, MSS can be upgraded. */

		if (!(flags & BPF_F_ADJ_ROOM_FIXED_GSO))

			skb_increase_gso_size(shinfo, len_diff);



		/* Header must be checked, and gso_segs recomputed. */

		shinfo->gso_type |= SKB_GSO_DODGY;

		shinfo->gso_segs = 0;
@@ -3037,7 +3053,7 @@ BPF_CALL_4(bpf_skb_adjust_room, struct sk_buff *, skb, s32, len_diff, 
	u32 off;

	int ret;



	if (unlikely(flags))

	if (unlikely(flags & ~BPF_F_ADJ_ROOM_MASK))

		return -EINVAL;

	if (unlikely(len_diff_abs > 0xfffU))

		return -EFAULT;
@@ -3065,8 +3081,8 @@ BPF_CALL_4(bpf_skb_adjust_room, struct sk_buff *, skb, s32, len_diff, 
			 !skb_is_gso(skb))))

		return -ENOTSUPP;



	ret = shrink ? bpf_skb_net_shrink(skb, off, len_diff_abs) :

		       bpf_skb_net_grow(skb, off, len_diff_abs);

	ret = shrink ? bpf_skb_net_shrink(skb, off, len_diff_abs, flags) :

		       bpf_skb_net_grow(skb, off, len_diff_abs, flags);



	bpf_compute_data_pointers(skb);

	return ret;

CRA Git | Maintained and supported by SUSTech CRA and CCSE