Commit 2278c5ac authored by Jeff Dike's avatar Jeff Dike Committed by Linus Torvalds
Browse files

uml: use of a public MAC is a warning, not an error 



Downgrade one of the MAC validity checks.  If it's one that could be possibly
assigned to a physical NIC, then nothing will break.  So, emit a warning in
this case, but keep the requested MAC.

Signed-off-by: default avatarJeff Dike <jdike@linux.intel.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent cc0be0fb

arch/um/drivers/net_kern.c

+4 −5
Original line number Diff line number Diff line
@@ -343,14 +343,13 @@ static void setup_etheraddr(char *str, unsigned char *addr, char *name) 
	}

	if (!is_local_ether_addr(addr)) {

		printk(KERN_WARNING

		       "Warning: attempt to assign a globally valid ethernet "

		       "Warning: Assigning a globally valid ethernet "

		       "address to a device\n");

		printk(KERN_WARNING "You should better enable the 2nd "

		       "rightmost bit in the first byte of the MAC,\n");

		printk(KERN_WARNING "You should set the 2nd rightmost bit in "

		       "the first byte of the MAC,\n");

		printk(KERN_WARNING "i.e. %02x:%02x:%02x:%02x:%02x:%02x\n",

		       addr[0] | 0x02, addr[1], addr[2], addr[3], addr[4],

		       addr[5]);

		goto random;

	}

	return;

CRA Git | Maintained and supported by SUSTech CRA and CCSE