Commit 2275cde4 authored by Trond Myklebust's avatar Trond Myklebust
Browse files

SUNRPC: Queue latency-sensitive socket tasks to xprtiod 



The response to a write_space notification is very latency sensitive,
so we should queue it to the lower latency xprtiod_workqueue. This
is something we already do for the other cases where an rpc task
holds the transport XPRT_LOCKED bitlock.

Signed-off-by: default avatarTrond Myklebust <trond.myklebust@primarydata.com>
parent 0c8cbcd3

include/linux/sunrpc/sched.h

+3 −0
Original line number Diff line number Diff line
@@ -229,6 +229,9 @@ void rpc_sleep_on_priority(struct rpc_wait_queue *, 
					struct rpc_task *,

					rpc_action action,

					int priority);

void rpc_wake_up_queued_task_on_wq(struct workqueue_struct *wq,

		struct rpc_wait_queue *queue,

		struct rpc_task *task);

void		rpc_wake_up_queued_task(struct rpc_wait_queue *,

					struct rpc_task *);

void		rpc_wake_up(struct rpc_wait_queue *);

net/sunrpc/sched.c

+12 −0
Original line number Diff line number Diff line
@@ -458,6 +458,18 @@ static void rpc_wake_up_task_queue_locked(struct rpc_wait_queue *queue, struct r 
	rpc_wake_up_task_on_wq_queue_locked(rpciod_workqueue, queue, task);

}



/*

 * Wake up a task on a specific queue

 */

void rpc_wake_up_queued_task_on_wq(struct workqueue_struct *wq,

		struct rpc_wait_queue *queue,

		struct rpc_task *task)

{

	spin_lock_bh(&queue->lock);

	rpc_wake_up_task_on_wq_queue_locked(wq, queue, task);

	spin_unlock_bh(&queue->lock);

}



/*

 * Wake up a task on a specific queue

 */

net/sunrpc/xprt.c

+2 −1
Original line number Diff line number Diff line
@@ -517,7 +517,8 @@ void xprt_write_space(struct rpc_xprt *xprt) 
	if (xprt->snd_task) {

		dprintk("RPC:       write space: waking waiting task on "

				"xprt %p\n", xprt);

		rpc_wake_up_queued_task(&xprt->pending, xprt->snd_task);

		rpc_wake_up_queued_task_on_wq(xprtiod_workqueue,

				&xprt->pending, xprt->snd_task);

	}

	spin_unlock_bh(&xprt->transport_lock);

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE