Commit 2253ed4b authored by Linus Walleij's avatar Linus Walleij Committed by Ulf Hansson
Browse files

mmc: mmci: Support any block sizes for ux500v2 and qcom variant 

For the ux500v2 variant of the PL18x block, any block sizes
are supported. This is necessary to support some SDIO
transfers. This also affects the QCOM MMCI variant and the
ST micro variant.

For Ux500 an additional quirk only allowing DMA on blocks
that are a power of two is needed. This might be a bug in
the DMA engine (DMA40) or the MMCI or in the interconnect,
but the most likely is the MMCI, as transfers of these
sizes work fine for other devices using the same DMA
engine. DMA works fine also with SDIO as long as the
blocksize is a power of 2.

This patch has proven necessary for enabling SDIO for WLAN on
PostmarketOS-based Ux500 platforms.

What we managed to test in practice is Broadcom WiFi over
SDIO on the Ux500 based Samsung GT-I8190 and GT-S7710.
This WiFi chip, BCM4334 works fine after the patch.

Before this patch:

brcmfmac: brcmf_fw_alloc_request: using brcm/brcmfmac4334-sdio
	  for chip BCM4334/3
mmci-pl18x 80118000.sdi1_per2: unsupported block size (60 bytes)
brcmfmac: brcmf_sdiod_ramrw: membytes transfer failed
brcmfmac: brcmf_sdio_download_code_file: error -22 on writing
	  434236 membytes at 0x00000000
brcmfmac: brcmf_sdio_download_firmware: dongle image file download
	  failed

After this patch:

brcmfmac: brcmf_c_preinit_dcmds: Firmware: BCM4334/3 wl0:
	  Nov 21 2012 00:21:28 version 6.10.58.813 (B2) FWID 01-0

Bringing up networks, discovering networks with "iw dev wlan0 scan"
and connecting works fine from this point.

This patch is inspired by Ulf Hansson's patch
http://www.spinics.net/lists/linux-mmc/msg12160.html



As the DMA engines on these platforms may now get block sizes
they were not used to before, make sure to also respect if
the DMA engine says "no" to a transfer.

Make a drive-by fix for datactrl_blocksz, misspelled.

Cc: Ludovic Barre <ludovic.barre@st.com>
Cc: Brian Masney <masneyb@onstation.org>
Cc: Stephan Gerhold <stephan@gerhold.net>
Cc: Niklas Cassel <niklas.cassel@linaro.org>
Cc: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
Signed-off-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Tested-by: default avatarStephan Gerhold <stephan@gerhold.net>
Link: https://lore.kernel.org/r/20191217143952.2885-1-linus.walleij@linaro.org
parent 67d7d920

drivers/mmc/host/mmci.c

+30 −4
Original line number Diff line number Diff line
@@ -169,6 +169,8 @@ static struct variant_data variant_ux500 = { 
	.cmdreg_srsp		= MCI_CPSM_RESPONSE,

	.datalength_bits	= 24,

	.datactrl_blocksz	= 11,

	.datactrl_any_blocksz	= true,

	.dma_power_of_2		= true,

	.datactrl_mask_sdio	= MCI_DPSM_ST_SDIOEN,

	.st_sdio		= true,

	.st_clkdiv		= true,
@@ -202,6 +204,8 @@ static struct variant_data variant_ux500v2 = { 
	.datactrl_mask_ddrmode	= MCI_DPSM_ST_DDRMODE,

	.datalength_bits	= 24,

	.datactrl_blocksz	= 11,

	.datactrl_any_blocksz	= true,

	.dma_power_of_2		= true,

	.datactrl_mask_sdio	= MCI_DPSM_ST_SDIOEN,

	.st_sdio		= true,

	.st_clkdiv		= true,
@@ -261,6 +265,7 @@ static struct variant_data variant_stm32_sdmmc = { 
	.datacnt_useless	= true,

	.datalength_bits	= 25,

	.datactrl_blocksz	= 14,

	.datactrl_any_blocksz	= true,

	.stm32_idmabsize_mask	= GENMASK(12, 5),

	.busy_timeout		= true,

	.busy_detect		= true,
@@ -284,6 +289,7 @@ static struct variant_data variant_qcom = { 
	.data_cmd_enable	= MCI_CPSM_QCOM_DATCMD,

	.datalength_bits	= 24,

	.datactrl_blocksz	= 11,

	.datactrl_any_blocksz	= true,

	.pwrreg_powerup		= MCI_PWR_UP,

	.f_max			= 208000000,

	.explicit_mclk_control	= true,
@@ -452,10 +458,11 @@ static void mmci_dma_setup(struct mmci_host *host) 
static int mmci_validate_data(struct mmci_host *host,

			      struct mmc_data *data)

{

	struct variant_data *variant = host->variant;



	if (!data)

		return 0;



	if (!is_power_of_2(data->blksz)) {

	if (!is_power_of_2(data->blksz) && !variant->datactrl_any_blocksz) {

		dev_err(mmc_dev(host->mmc),

			"unsupported block size (%d bytes)\n", data->blksz);

		return -EINVAL;
@@ -520,7 +527,9 @@ static int mmci_dma_start(struct mmci_host *host, unsigned int datactrl) 
		 "Submit MMCI DMA job, sglen %d blksz %04x blks %04x flags %08x\n",

		 data->sg_len, data->blksz, data->blocks, data->flags);



	host->ops->dma_start(host, &datactrl);

	ret = host->ops->dma_start(host, &datactrl);

	if (ret)

		return ret;



	/* Trigger the DMA transfer */

	mmci_write_datactrlreg(host, datactrl);
@@ -888,6 +897,18 @@ static int _mmci_dmae_prep_data(struct mmci_host *host, struct mmc_data *data, 
	if (data->blksz * data->blocks <= variant->fifosize)

		return -EINVAL;



	/*

	 * This is necessary to get SDIO working on the Ux500. We do not yet

	 * know if this is a bug in:

	 * - The Ux500 DMA controller (DMA40)

	 * - The MMCI DMA interface on the Ux500

	 * some power of two blocks (such as 64 bytes) are sent regularly

	 * during SDIO traffic and those work fine so for these we enable DMA

	 * transfers.

	 */

	if (host->variant->dma_power_of_2 && !is_power_of_2(data->blksz))

		return -EINVAL;



	device = chan->device;

	nr_sg = dma_map_sg(device->dev, data->sg, data->sg_len,

			   mmc_get_dma_dir(data));
@@ -938,9 +959,14 @@ int mmci_dmae_prep_data(struct mmci_host *host, 
int mmci_dmae_start(struct mmci_host *host, unsigned int *datactrl)

{

	struct mmci_dmae_priv *dmae = host->dma_priv;

	int ret;



	host->dma_in_progress = true;

	dmaengine_submit(dmae->desc_current);

	ret = dma_submit_error(dmaengine_submit(dmae->desc_current));

	if (ret < 0) {

		host->dma_in_progress = false;

		return ret;

	}

	dma_async_issue_pending(dmae->cur);



	*datactrl |= MCI_DPSM_DMAENABLE;

drivers/mmc/host/mmci.h

+7 −1
Original line number Diff line number Diff line
@@ -279,7 +279,11 @@ struct mmci_host; 
 * @stm32_clkdiv: true if using a STM32-specific clock divider algorithm

 * @datactrl_mask_ddrmode: ddr mode mask in datactrl register.

 * @datactrl_mask_sdio: SDIO enable mask in datactrl register

 * @datactrl_blksz: block size in power of two

 * @datactrl_blocksz: block size in power of two

 * @datactrl_any_blocksz: true if block any block sizes are accepted by

 *		  hardware, such as with some SDIO traffic that send

 *		  odd packets.

 * @dma_power_of_2: DMA only works with blocks that are a power of 2.

 * @datactrl_first: true if data must be setup before send command

 * @datacnt_useless: true if you could not use datacnt register to read

 *		     remaining data
@@ -326,6 +330,8 @@ struct variant_data { 
	unsigned int		datactrl_mask_ddrmode;

	unsigned int		datactrl_mask_sdio;

	unsigned int		datactrl_blocksz;

	u8			datactrl_any_blocksz:1;

	u8			dma_power_of_2:1;

	u8			datactrl_first:1;

	u8			datacnt_useless:1;

	u8			st_sdio:1;

CRA Git | Maintained and supported by SUSTech CRA and CCSE