Commit 2230ca0d authored Aug 01, 2018 by Trond Myklebust Committed by Anna Schumaker Aug 08, 2018

pnfs: pnfs_find_lseg() should not check NFS_LSEG_LAYOUTRETURN

Layout segment validity is determined only by the NFS_LSEG_VALID flag. If
it is set, the layout segment is finable. As it is, when the flexfiles
driver sets NFS_LSEG_LAYOUTRETURN to indicate that we cannot discard
the layout segment, but that it must be returned, then this can result
in an unnecessary layoutget storm.

Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>

parent 01e03bdc

fs/nfs/pnfs.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -1650,7 +1650,6 @@ pnfs_find_lseg(struct pnfs_layout_hdr *lo,

		list_for_each_entry(lseg, &lo->plh_segs, pls_list) {
		if (test_bit(NFS_LSEG_VALID, &lseg->pls_flags) &&
		!test_bit(NFS_LSEG_LAYOUTRETURN, &lseg->pls_flags) &&
		pnfs_lseg_range_match(&lseg->pls_range, range,
		strict_iomode)) {
		ret = pnfs_get_lseg(lseg);

Admin message