Commit 2222ce0f authored Apr 29, 2015 by Nathan Fontenot Committed by Michael Ellerman May 11, 2015

powerpc/pseries: Fix possible leaked device node reference



Failure return from dlpar_configure_connector when dlpar adding cpus
results in leaking references to the cpus parent device node. Move the
call to of_node_put() prior to checking the result of
dlpar_configure_connector.

Fixes: 8d5ff320 ("powerpc/pseries: Make dlpar_configure_connector parent node aware")

Signed-off-by: Nathan Fontenot <nfont@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

parent 202648a6

arch/powerpc/platforms/pseries/dlpar.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -421,11 +421,10 @@ static ssize_t dlpar_cpu_probe(const char *buf, size_t count)
		return -ENODEV;

		dn = dlpar_configure_connector(cpu_to_be32(drc_index), parent);
		of_node_put(parent);
		if (!dn)
		return -EINVAL;

		of_node_put(parent);

		rc = dlpar_attach_node(dn);
		if (rc) {
		dlpar_release_drc(drc_index);

Admin message