Commit 221255ae authored Dec 01, 2015 by Hannes Reinecke Committed by Martin K. Petersen Dec 02, 2015

scsi: ignore errors from scsi_dh_add_device()



device handler initialisation might fail due to a number of
reasons. But as device_handlers are optional this shouldn't
cause us to disable the device entirely.
So just ignore errors from scsi_dh_add_device().

Reviewed-by: Johannes Thumshirn <jthumshirn@suse.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 41f95dd2

drivers/scsi/scsi_sysfs.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -1120,11 +1120,12 @@ int scsi_sysfs_add_sdev(struct scsi_device *sdev)
		}

		error = scsi_dh_add_device(sdev);
		if (error) {
		if (error)
		/*
		* device_handler is optional, so any error can be ignored
		*/
		sdev_printk(KERN_INFO, sdev,
		"failed to add device handler: %d\n", error);
		return error;
		}

		device_enable_async_suspend(&sdev->sdev_dev);
		error = device_add(&sdev->sdev_dev);

Admin message