Commit 22117ea4 authored Aug 21, 2007 by Andy Whitcroft Committed by David S. Miller Aug 21, 2007

[IRDA] irda_nl_get_mode: always results in failure



It seems an extraneous trailing ';' has slipped in to the error handling for a
name registration failure causing the error path to trigger unconditionally.

Signed-off-by: Andy Whitcroft <apw@shadowen.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Samuel Ortiz <samuel@sortiz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 06c7af56

net/irda/irnetlink.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -106,7 +106,7 @@ static int irda_nl_get_mode(struct sk_buff skb, struct genl_info info)
	}		}

	if(nla_put_string(msg, IRDA_NL_ATTR_IFNAME,		if(nla_put_string(msg, IRDA_NL_ATTR_IFNAME,
	dev->name));		dev->name))
	goto err_out;		goto err_out;

	if(nla_put_u32(msg, IRDA_NL_ATTR_MODE, irlap->mode))		if(nla_put_u32(msg, IRDA_NL_ATTR_MODE, irlap->mode))

Admin message