ACPI: processor: restrict early _PDC to opt-in platforms (2205cbe8) · Commits · 戴 / test

Commit (ACPI: processor: call _PDC early) blindly walks the namespace and calls _PDC on every processor object it finds. This change may cause issues on platforms that declare dummy values for SSDTs on non-present processors (disabled in MADT). When we call _PDC and dynamically attempt to execute the AML Load() op on these dummy SSDTs, there's no telling what might happen. Rather than finding every platform that has bogus SSDTs, restrict early _PDC calls to platforms that are known to need early evaluation of _PDC. This is a minimal, temporary fix (given the context of the current release cycle). A real solution of checking the MADT for non-present processors will be written for the next merge window. References: http://bugzilla.kernel.org/show_bug.cgi?id=14710 http://bugzilla.kernel.org/show_bug.cgi?id=14954 Signed-off-by:

Alex Chiang <achiang@hp.com> Signed-off-by:

Len Brown <len.brown@intel.com>

drivers/acpi/processor_pdc.c

+30 −0

Original line number	Diff line number	Diff line
		@@ -144,6 +144,29 @@ void acpi_processor_set_pdc(acpi_handle handle)
		}
		EXPORT_SYMBOL_GPL(acpi_processor_set_pdc);

		static int early_pdc_optin;
		static int set_early_pdc_optin(const struct dmi_system_id *id)
		{
		early_pdc_optin = 1;
		return 0;
		}

		static struct dmi_system_id __cpuinitdata early_pdc_optin_table[] = {
		{
		set_early_pdc_optin, "HP Envy", {
		DMI_MATCH(DMI_BIOS_VENDOR, "Hewlett-Packard"),
		DMI_MATCH(DMI_PRODUCT_NAME, "HP Envy") }, NULL},
		{
		set_early_pdc_optin, "HP Pavilion dv6", {
		DMI_MATCH(DMI_BIOS_VENDOR, "Hewlett-Packard"),
		DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion dv6") }, NULL},
		{
		set_early_pdc_optin, "HP Pavilion dv7", {
		DMI_MATCH(DMI_BIOS_VENDOR, "Hewlett-Packard"),
		DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion dv7") }, NULL},
		{},
		};

		static acpi_status
		early_init_pdc(acpi_handle handle, u32 lvl, void context, void *rv)
		{
		@@ -159,6 +182,13 @@ void acpi_early_processor_set_pdc(void)
		*/
		dmi_check_system(processor_idle_dmi_table);

		/*
		* Allow systems to opt-in to early _PDC evaluation.
		*/
		dmi_check_system(early_pdc_optin_table);
		if (!early_pdc_optin)
		return;

		acpi_walk_namespace(ACPI_TYPE_PROCESSOR, ACPI_ROOT_OBJECT,
		ACPI_UINT32_MAX,
		early_init_pdc, NULL, NULL, NULL);

Admin message