Commit 2205a6ea authored Feb 17, 2011 by Jiri Bohac Committed by David S. Miller Feb 19, 2011

sctp: fix reporting of unknown parameters



commit 5fa782c2 re-worked the
handling of unknown parameters. sctp_init_cause_fixed() can now
return -ENOSPC if there is not enough tailroom in the error
chunk skb. When this happens, the error header is not appended to
the error chunk. In that case, the payload of the unknown parameter
should not be appended either.

Signed-off-by: Jiri Bohac <jbohac@suse.cz>
Acked-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 226111d1

net/sctp/sm_make_chunk.c

+5 −5

Original line number	Diff line number	Diff line
		@@ -2029,8 +2029,8 @@ static sctp_ierror_t sctp_process_unk_param(const struct sctp_association *asoc,
		*errp = sctp_make_op_error_fixed(asoc, chunk);

		if (*errp) {
		sctp_init_cause_fixed(*errp, SCTP_ERROR_UNKNOWN_PARAM,
		WORD_ROUND(ntohs(param.p->length)));
		if (!sctp_init_cause_fixed(*errp, SCTP_ERROR_UNKNOWN_PARAM,
		WORD_ROUND(ntohs(param.p->length))))
		sctp_addto_chunk_fixed(*errp,
		WORD_ROUND(ntohs(param.p->length)),
		param.v);

Admin message