Commit 21ef77de authored Aug 15, 2019 by Stephen Boyd

rtc: sun6i: Don't reference clk_init_data after registration

A future patch is going to change semantics of clk_register() so that
clk_hw::init is guaranteed to be NULL after a clk is registered. Avoid
referencing this member here so that we don't run into NULL pointer
exceptions.

Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Reported-by: "kernelci.org bot" <bot@kernelci.org>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Link: https://lkml.kernel.org/r/20190815160020.183334-4-sboyd@kernel.org

Acked-by: Chen-Yu Tsai <wens@csie.org>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

parent 1a4549c1

drivers/rtc/rtc-sun6i.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -279,7 +279,7 @@ static void __init sun6i_rtc_clk_init(struct device_node *node,

		of_property_read_string_index(node, "clock-output-names", 1,
		&clkout_name);
		rtc->ext_losc = clk_register_gate(NULL, clkout_name, rtc->hw.init->name,
		rtc->ext_losc = clk_register_gate(NULL, clkout_name, init.name,
		0, rtc->base + SUN6I_LOSC_OUT_GATING,
		SUN6I_LOSC_OUT_GATING_EN_OFFSET, 0,
		&rtc->lock);

Admin message