Commit 21d9629a authored Oct 07, 2016 by Alex Sidorenko Committed by David S. Miller Oct 07, 2016

Fixing a bug in team driver due to incorrect 'unsigned int' to 'int' conversion



Roundrobin runner of team driver uses 'unsigned int' variable to count
the number of sent_packets. Later it is passed to a subroutine
team_num_to_port_index(struct team *team, int num) as 'num' and when
we reach MAXINT (2**31-1), 'num' becomes negative.

This leads to using incorrect hash-bucket for port lookup
and as a result, packets are dropped. The fix consists of changing
'int num' to 'unsigned int num'. Testing of a fixed kernel shows that
there is no packet drop anymore.

Signed-off-by: Alex Sidorenko <alexandre.sidorenko@hpe.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 7d3cfc36

include/linux/if_team.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -245,7 +245,7 @@ static inline struct team_port team_get_port_by_index(struct team team,
		return NULL;
		}

		static inline int team_num_to_port_index(struct team *team, int num)
		static inline int team_num_to_port_index(struct team *team, unsigned int num)
		{
		int en_port_count = ACCESS_ONCE(team->en_port_count);

Admin message