drm/ast: Don't use ast->dev if dev is available (21d79b69) · Commits · 戴 / test

Several places in ast use ast->dev, when a dev pointer is already available within the function. Remove the extra indirection. No functional changes made. This is just a small cleanup before embedding the DRM device instance in struct ast_private. Signed-off-by:

Thomas Zimmermann <tzimmermann@suse.de> Acked-by:

Daniel Vetter <daniel.vetter@ffwll.ch> Acked-by:

Sam Ravnborg <sam@ravnborg.org> Link: https://patchwork.freedesktop.org/patch/msgid/20200730135206.30239-6-tzimmermann@suse.de

drivers/gpu/drm/ast/ast_mode.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1079,7 +1079,7 @@ int ast_mode_config_init(struct ast_private *ast)
		dev->mode_config.min_height = 0;
		dev->mode_config.preferred_depth = 24;
		dev->mode_config.prefer_shadow = 1;
		dev->mode_config.fb_base = pci_resource_start(ast->dev->pdev, 0);
		dev->mode_config.fb_base = pci_resource_start(dev->pdev, 0);

		if (ast->chip == AST2100 \|\|
		ast->chip == AST2200 \|\|

drivers/gpu/drm/ast/ast_post.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -368,9 +368,9 @@ void ast_post_gpu(struct drm_device *dev)
		u32 reg;
		struct ast_private *ast = to_ast_private(dev);

		pci_read_config_dword(ast->dev->pdev, 0x04, &reg);
		pci_read_config_dword(dev->pdev, 0x04, &reg);
		reg \|= 0x3;
		pci_write_config_dword(ast->dev->pdev, 0x04, reg);
		pci_write_config_dword(dev->pdev, 0x04, reg);

		ast_enable_vga(dev);
		ast_open_key(ast);

Admin message