Commit 21ba2379 authored Jun 25, 2019 by Rafael J. Wysocki

ACPI: PM: Avoid evaluating _PS3 on transitions from D3hot to D3cold



If the power state of a device with ACPI PM is changed from D3hot to
D3cold, it merely is a matter of dropping references to additional
power resources (specifically, those in the list returned by _PR3),
and the _PS3 method should not be invoked for the device then (as
it has already been evaluated during the previous transition to
D3hot).

Fixes: 20dacb71 (ACPI / PM: Rework device power management to follow ACPI 6)
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>

parent a3487d8f

drivers/acpi/device_pm.c

+9 −3

Original line number	Diff line number	Diff line
		@@ -210,9 +210,15 @@ int acpi_device_set_power(struct acpi_device *device, int state)
		return -ENODEV;
		}

		/*
		* If the device goes from D3hot to D3cold, _PS3 has been
		* evaluated for it already, so skip it in that case.
		*/
		if (device->power.state < ACPI_STATE_D3_HOT) {
		result = acpi_dev_pm_explicit_set(device, state);
		if (result)
		goto end;
		}

		if (device->power.flags.power_resources)
		result = acpi_power_transition(device, target_state);

Admin message