Commit 21a66717 authored by Vasily Gorbik's avatar Vasily Gorbik
Browse files

s390/kasan: make sure int handler always run with DAT on 



Since commit 998f5bbe ("s390/kasan: fix early pgm check handler
execution") early pgm check handler is executed with DAT on if Kasan
is enabled.

Still there is a window between setup_lowcore_dat_off() and
setup_lowcore_dat_on() when int handlers could be executed with DAT off
under Kasan. If this happens the kernel ends up in pgm check loop due
to Kasan shadow memory access attempts.

With Kasan enabled paging is initialized much earlier and DAT flag has to
be on at all times instrumented code is executed. Make sure int handlers
are set up to be called with DAT on right away in this case.

Signed-off-by: default avatarVasily Gorbik <gor@linux.ibm.com>
parent 5627b922

arch/s390/kernel/setup.c

+8 −4
Original line number Diff line number Diff line
@@ -372,8 +372,12 @@ void __init arch_call_rest_init(void) 


static void __init setup_lowcore_dat_off(void)

{

	unsigned long int_psw_mask = PSW_KERNEL_BITS;

	struct lowcore *lc;



	if (IS_ENABLED(CONFIG_KASAN))

		int_psw_mask |= PSW_MASK_DAT;



	/*

	 * Setup lowcore for boot cpu

	 */
@@ -385,15 +389,15 @@ static void __init setup_lowcore_dat_off(void) 


	lc->restart_psw.mask = PSW_KERNEL_BITS;

	lc->restart_psw.addr = (unsigned long) restart_int_handler;

	lc->external_new_psw.mask = PSW_KERNEL_BITS | PSW_MASK_MCHECK;

	lc->external_new_psw.mask = int_psw_mask | PSW_MASK_MCHECK;

	lc->external_new_psw.addr = (unsigned long) ext_int_handler;

	lc->svc_new_psw.mask = PSW_KERNEL_BITS | PSW_MASK_MCHECK;

	lc->svc_new_psw.mask = int_psw_mask | PSW_MASK_MCHECK;

	lc->svc_new_psw.addr = (unsigned long) system_call;

	lc->program_new_psw.mask = PSW_KERNEL_BITS | PSW_MASK_MCHECK;

	lc->program_new_psw.mask = int_psw_mask | PSW_MASK_MCHECK;

	lc->program_new_psw.addr = (unsigned long) pgm_check_handler;

	lc->mcck_new_psw.mask = PSW_KERNEL_BITS;

	lc->mcck_new_psw.addr = (unsigned long) mcck_int_handler;

	lc->io_new_psw.mask = PSW_KERNEL_BITS | PSW_MASK_MCHECK;

	lc->io_new_psw.mask = int_psw_mask | PSW_MASK_MCHECK;

	lc->io_new_psw.addr = (unsigned long) io_int_handler;

	lc->clock_comparator = clock_comparator_max;

	lc->nodat_stack = ((unsigned long) &init_thread_union)

CRA Git | Maintained and supported by SUSTech CRA and CCSE