Commit 2192a8dd authored Aug 09, 2017 by Gustavo A. R. Silva Committed by Boris Brezillon Aug 23, 2017

mtd: nand: sh_flctl: fix error return code in flctl_probe()

platform_get_irq() returns an error code, but the sh_flctl
driver ignores it and always returns -ENXIO. This is not correct
and, prevents -EPROBE_DEFER from being propagated properly.

Print and propagate the return value of platform_get_irq on failure.

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>

parent dbf5f642

drivers/mtd/nand/sh_flctl.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1141,8 +1141,8 @@ static int flctl_probe(struct platform_device *pdev)

		irq = platform_get_irq(pdev, 0);
		if (irq < 0) {
		dev_err(&pdev->dev, "failed to get flste irq data\n");
		return -ENXIO;
		dev_err(&pdev->dev, "failed to get flste irq data: %d\n", irq);
		return irq;
		}

		ret = devm_request_irq(&pdev->dev, irq, flctl_handle_flste, IRQF_SHARED,

Admin message