Commit 216b4400 authored Dec 03, 2019 by Dan Carpenter Committed by Kalle Valo Dec 18, 2019

brcmfmac: Fix use after free in brcmf_sdio_readframes()



The brcmu_pkt_buf_free_skb() function frees "pkt" so it leads to a
static checker warning:

    drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:1974 brcmf_sdio_readframes()
    error: dereferencing freed memory 'pkt'

It looks like there was supposed to be a continue after we free "pkt".

Fixes: 4754fcee ("brcmfmac: streamline SDIO read frame routine")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Franky Lin <franky.lin@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

parent 960da557

drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1935,6 +1935,7 @@ static uint brcmf_sdio_readframes(struct brcmf_sdio *bus, uint maxframes)
		BRCMF_SDIO_FT_NORMAL)) {
		rd->len = 0;
		brcmu_pkt_buf_free_skb(pkt);
		continue;
		}
		bus->sdcnt.rx_readahead_cnt++;
		if (rd->len != roundup(rd_new.len, 16)) {

Admin message