Fix dnotify/close race (214b7049) · Commits · 戴 / test

We have a race between fcntl() and close() that can lead to dnotify_struct inserted into inode's list *after* the last descriptor had been gone from current->files. Since that's the only point where dnotify_struct gets evicted, we are screwed - it will stick around indefinitely. Even after struct file in question is gone and freed. Worse, we can trigger send_sigio() on it at any later point, which allows to send an arbitrary signal to arbitrary process if we manage to apply enough memory pressure to get the page that used to host that struct file and fill it with the right pattern... Signed-off-by:

Al Viro <viro@zeniv.linux.org.uk> Signed-off-by:

Linus Torvalds <torvalds@linux-foundation.org>

fs/dnotify.c

+11 −0

Original line number	Diff line number	Diff line
		@@ -20,6 +20,7 @@
		#include <linux/init.h>
		#include <linux/spinlock.h>
		#include <linux/slab.h>
		#include <linux/file.h>

		int dir_notify_enable __read_mostly = 1;

		@@ -66,6 +67,7 @@ int fcntl_dirnotify(int fd, struct file *filp, unsigned long arg)
		struct dnotify_struct **prev;
		struct inode *inode;
		fl_owner_t id = current->files;
		struct file *f;
		int error = 0;

		if ((arg & ~DN_MULTISHOT) == 0) {
		@@ -92,6 +94,15 @@ int fcntl_dirnotify(int fd, struct file *filp, unsigned long arg)
		prev = &odn->dn_next;
		}

		rcu_read_lock();
		f = fcheck(fd);
		rcu_read_unlock();
		/* we'd lost the race with close(), sod off silently */
		/* note that inode->i_lock prevents reordering problems
		* between accesses to descriptor table and ->i_dnotify */
		if (f != filp)
		goto out_free;

		error = __f_setown(filp, task_pid(current), PIDTYPE_PID, 0);
		if (error)
		goto out_free;

Admin message