Commit 2130c6b4 authored Jun 22, 2020 by Paul E. McKenney

nocb: Remove show_rcu_nocb_state() false positive printout



The rcu_data structure's ->nocb_timer field is used to defer wakeups of
the corresponding no-CBs CPU's grace-period kthread ("rcuog*"), and that
structure's ->nocb_defer_wakeup field is used to track such deferral.
This means that the show_rcu_nocb_state() printing an error when those
fields are set for a CPU not corresponding to a no-CBs grace-period
kthread is erroneous.

This commit therefore switches the check from ->nocb_timer to
->nocb_bypass_timer and removes the check of ->nocb_defer_wakeup.

Signed-off-by: Paul E. McKenney <paulmck@kernel.org>

parent 9b1ce0ac

kernel/rcu/tree_plugin.h

+2 −3

Original line number	Diff line number	Diff line
		@@ -2411,10 +2411,9 @@ static void show_rcu_nocb_state(struct rcu_data *rdp)
		return;

		waslocked = raw_spin_is_locked(&rdp->nocb_gp_lock);
		wastimer = timer_pending(&rdp->nocb_timer);
		wastimer = timer_pending(&rdp->nocb_bypass_timer);
		wassleep = swait_active(&rdp->nocb_gp_wq);
		if (!rdp->nocb_defer_wakeup && !rdp->nocb_gp_sleep &&
		!waslocked && !wastimer && !wassleep)
		if (!rdp->nocb_gp_sleep && !waslocked && !wastimer && !wassleep)
		return; /* Nothing untowards. */

		pr_info(" nocb GP activity on CB-only CPU!!! %c%c%c%c %c\n",

Admin message